[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20070209214203.GE28386@flower.upol.cz>
Date: Fri, 9 Feb 2007 22:42:03 +0100
From: Oleg Verych <olecom@...wer.upol.cz>
To: Roman Zippel <zippel@...ux-m68k.org>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>,
linux-kernel@...r.kernel.org
Subject: Re: The who needs reviews anyways [PATCH]
On Fri, Feb 09, 2007 at 12:35:04PM +0100, Roman Zippel wrote:
[]
> > > +$(error bash is required to build the kernel)
> > > +endif
> > > +SHELL := $(CONFIG_SHELL)
> >
> > here is policy to have `bash' introduced, so due to original
> > issue, where `root' users ended with removed /dev/null, may policy to have
> > `non root' user to build kernel be added? Thus
>
> I doubt gentoo user will like you for that and above is more a de facto
> requirement that bash is needed for kbuild. The alternative is to
> introduce a new policy that everything is POSIX clean.
Bad thing is, that `man bash' has no clean line between `sh' and
bash-specific features. POSIX it or `common practice' doesn't matter,
one just must try to test shell scripts with `busybox' or any other `sh'
compatible shell.
> > this:
> > > + rm -f "$$TMP")
> >
> > may be removed, and to make TMP=/dev/null? And to forget currently about
> > my silly symlinks, and this crappy sets of output files?
>
> This still wouldn't work, as these tests are also done when running 'make
> install'.
and/or "make modules_install", and this must be fixed: to have only one
configuration-run. And then to use its results.
> > > -as-instr = $(call checker-shell,\
> > > - printf "$(1)" | $(CC) $(AFLAGS) -c -xassembler -o $$OUT -,$(2),$(3))
> >
> > `printf $(1)' is pretty enough.
>
> As Andreas suggested 'printf "%b" "$(1)"' would be the other alternative.
It will not help against single double quote in $(1)
____
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists