[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070210152226.GA3482@interface.famille.thibault.fr>
Date: Sat, 10 Feb 2007 16:22:26 +0100
From: Samuel Thibault <samuel.thibault@...-lyon.org>
To: Jeff Garzik <jeff@...zik.org>
Cc: Levitsky Maxim <maximlevitsky@...oo.com>,
linux-kernel@...r.kernel.org, tori@...appy.mine.nu,
netdev@...r.kernel.org, sebastien.hinderer@...ia.fr
Subject: Re: [PATCH] [NETDEV] [000] dmfe : fix bugs and add features
Hi,
Jeff Garzik, le Fri 09 Feb 2007 16:15:26 -0500, a écrit :
> Levitsky Maxim wrote:
> >Before some time I decided to fix suspend/resume on my Davicom
> >network card. During development I also fixed couple of bugs and
> >added support for link detection and WOL Note : 2.6.20 already has
> >support for link detection , but it is broken when card has external
> >PHY, like mine.
> >
> >So here it goes:
> >
> >[PATCH] [NET] [001] dmfe : trivial/spelling fixes
> >[PATCH] [NET] [002] dmfe : Fix possible oops
> >[PATCH] [NET] [003] dmfe : fix link detection
> >[PATCH] [NET] [004] dmfe : Add suspend/resume support
> >[PATCH] [NET] [005] dmfe : Add support for wake-on-lan
>
> >Commit 7628b0a8c01a02966d2228bdf741ddedb128e8f8 (drivers/net/tulip/dmfe:
> >support basic carrier detection) breaks networking on my Davicom DM9009.
> >ethtool always reports there is no link. tcpdump shows incoming
> >packets, but TX is disabled. Reverting the above patch fixes the
> >problem.
>
> What about the above report?
>
> I would rather fix this first, before applying more patches on top of a
> problematic patch...
My patch wasn't implementing anything actually: it was just making the
existing-since-long link detection code available in ethtools.
Samuel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists