linux-kernel - i386: pit_latch_buggy has no effect.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20070210.173445.242527990.takada@mbf.nifty.com>
Date:	Sat, 10 Feb 2007 17:34:45 +0900 (JST)
From:	takada <takada@....nifty.com>
To:	linux-kernel@...r.kernel.org
Subject: i386: pit_latch_buggy has no effect.

Hi.
Eliminated the arch/i386/kernel/timers in 2.6.18, use clocksoures instead.
pit_latch_buggy was referred in timers/timer_tsc.c, and currently removed.
Therefore nobody refer it.
Until 2.6.17, MediaGX's TSC works correctly. after 2.6.18, warned
"TSC appears to be running slowly. Marking it as unstable". So marked 
unstable TSC when CS55x0.


diff -Naru a/arch/i386/kernel/cpu/cyrix.c b/arch/i386/kernel/cpu/cyrix.c
--- a/arch/i386/kernel/cpu/cyrix.c	2007-02-05 03:44:54.000000000 +0900
+++ b/arch/i386/kernel/cpu/cyrix.c	2007-02-10 16:11:31.000000000 +0900
@@ -278,7 +278,7 @@
 		 *  The 5510/5520 companion chips have a funky PIT.
 		 */  
 		if (pci_dev_present(cyrix_55x0))
-			pit_latch_buggy = 1;
+			mark_tsc_unstable();
 #endif
 		c->x86_cache_size=16;	/* Yep 16K integrated cache thats it */
 
diff -Naru a/arch/i386/kernel/time.c b/arch/i386/kernel/time.c
--- a/arch/i386/kernel/time.c	2007-02-05 03:44:54.000000000 +0900
+++ b/arch/i386/kernel/time.c	2007-02-10 16:12:04.000000000 +0900
@@ -70,8 +70,6 @@
 
 #include <asm/i8259.h>
 
-int pit_latch_buggy;              /* extern */
-
 #include "do_timer.h"
 
 unsigned int cpu_khz;	/* Detected as we calibrate the TSC */
diff -Naru a/include/asm-i386/timer.h b/include/asm-i386/timer.h
--- a/include/asm-i386/timer.h	2007-02-05 03:44:54.000000000 +0900
+++ b/include/asm-i386/timer.h	2007-02-10 16:12:21.000000000 +0900
@@ -5,8 +5,6 @@
 
 #define TICK_SIZE (tick_nsec / 1000)
 void setup_pit_timer(void);
-/* Modifiers for buggy PIT handling */
-extern int pit_latch_buggy;
 extern int timer_ack;
 extern int recalibrate_cpu_khz(void);
 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/