linux-kernel - Re: NAK new drivers without proper power management?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 11 Feb 2007 17:01:27 +0000
From:	Pavel Machek <pavel@....cz>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Robert Hancock <hancockr@...w.ca>, nigel@...el.suspend2.net,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: NAK new drivers without proper power management?

Hi!

> > > -ENOSYS is just not acceptable.
> > 
> > Well, it's probably more acceptable than silently doing nothing and the 
> > device failing or locking up the machine on resume, but I couldn't agree 
> > more that it's not what we want to be encouraging. Perfect may be the 
> > enemy of the good, but "works except no power management" is hardly what 
> > I would call good these days, more like pretty sloppy..
> 
> I think there are situations in which it can be justified, like:
> - The driver is not entirely finished, but we want to merge it early, because
> of many potential users,
> - The driver has only a few users who aren't interested in the suspend/resume
> functionality,
> - The device is undocumented and we don't know how to make it handle the
> suspend/resume (we may learn that in the future or not).
> 
> For this reason I 100% agree that we should _encourage_ implementing .suspend
> and .resume, but we should not make it an unbreakable rule cast in stone.

No rules are ever unbreakable, so that should be okay. 'Make it
suspend, if you can't for some good reason, at least return -ENOSYS
from .suspend' sounds good to me.
							Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/