linux-kernel - Re: [PATCH v4] Fix rmmod/read/write races in /proc entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070211203426.GB4095@ftp.linux.org.uk>
Date:	Sun, 11 Feb 2007 20:34:26 +0000
From:	Al Viro <viro@....linux.org.uk>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	Andrew Morton <akpm@...l.org>,
	Alexey Dobriyan <adobriyan@...nvz.org>,
	linux-kernel@...r.kernel.org, duncan.sands@...h.u-psud.fr
Subject: Re: [PATCH v4] Fix rmmod/read/write races in /proc entries

> Does it pass everyone's bullshit detectors?
 
Nice, but incomplete.  What we need to add is
	* procfs-specific file_operations shared by all regular files
on procfs.  Stuff in there would call methods from pde->proc_fops,
after having done the same kind of exclusion you are currently doing
in proc_file_read(), et.al.
	* always set ->f_op of regular files on procfs to that sucker.
Don't reset it to NULL during removal.
	* now that exclusion is done in wrappers, no need to do it in
proc_file_read().

That'll solve the rest of issues.  Eventually we might want to divorce
->proc_fops from file_operations (and trim it down), but that's a separate
story.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/