linux-kernel - Re: [patch] linux/io.h: forward declare struct pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070211034902.GA9077@infradead.org>
Date:	Sun, 11 Feb 2007 03:49:02 +0000
From:	Christoph Hellwig <hch@...radead.org>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Jeff Garzik <jgarzik@...ox.com>, Tejun Heo <htejun@...il.com>,
	linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org
Subject: Re: [patch] linux/io.h: forward declare struct pci_dev

On Sat, Feb 10, 2007 at 12:45:50PM +0100, Heiko Carstens wrote:
> From: Heiko Carstens <heiko.carstens@...ibm.com>
> 
> 9ac7849e35f705830f7b016ff272b0ff1f7ff759 causes this:
> 
>   CC      arch/s390/mm/ioremap.o
> In file included from arch/s390/mm/ioremap.c:18:
> include/linux/io.h:46:
> 	warning: "struct pci_dev" declared inside parameter list
> include/linux/io.h:46:
> 	warning: its scope is only this definition or declaration,
> 		 which is probably not what you want
> 
> Guess it's time to get rid of ioremap.c on s390 if possible...
> 
> Cc: Tejun Heo <htejun@...il.com>
> Cc: Jeff Garzik <jeff@...zik.org>
> Cc: Martin Schwidefsky <schwidefsky@...ibm.com>
> Signed-off-by: Heiko Carstens <heiko.carstens@...ibm.com>
> ---
>  include/linux/io.h |    1 +
>  1 files changed, 1 insertion(+)
> 
> Index: linux-2.6/include/linux/io.h
> ===================================================================
> --- linux-2.6.orig/include/linux/io.h
> +++ linux-2.6/include/linux/io.h
> @@ -22,6 +22,7 @@
>  #include <asm/io.h>
>  #include <asm/page.h>
>  
> +struct pci_dev;
>  struct device;

I haven't looked at what causes it, but any leakage of pci details
into io.h is bogus.  I'd suggest that the original submitter fixes
up that problem instead.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/