linux-kernel - Re: [patch] linux/io.h: forward declare struct pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070210225511.384f894b.randy.dunlap@oracle.com>
Date:	Sat, 10 Feb 2007 22:55:11 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Al Viro <viro@....linux.org.uk>
Cc:	Tejun Heo <htejun@...il.com>,
	Christoph Hellwig <hch@...radead.org>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Jeff Garzik <jgarzik@...ox.com>, linux-kernel@...r.kernel.org,
	linux-s390@...r.kernel.org
Subject: Re: [patch] linux/io.h: forward declare struct pci_dev

On Sun, 11 Feb 2007 06:34:31 +0000 Al Viro wrote:

> My current version:
> 
> >From 97f115834b5ebef4f04e0f18aaa10f78f43733a0 Mon Sep 17 00:00:00 2001
> From: Al Viro <viro@...iv.linux.org.uk>
> Date: Sat, 10 Feb 2007 23:41:09 -0500
> Subject: [PATCH] sort the devres mess out
> 
> Split the implementation-agnostic stuff in separate files.
> Make sure that targets using non-default request_irq() pull kernel/irq/devres.o
> Mark targets that have no ioport_map() and friends, protect the ioport-related
> Parts of lib/devres.o with corresponding ifdef (BTW, we need it in driver
> dependencies in quite a few of cases, so that symbol was needed anyway).
> 
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
> ---
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 1523046..7215152 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -29,6 +29,10 @@ config MMU
>  	bool
>  	default y
>  
> +config NO_IOPORT
> +	bool
> +	default n

Uh, I think that we would rather see a positive-sense symbol instead
of a negative one.  Any reason that this one prefers to be negative?

Thanks,
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/