lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070211082159.GT10050@ftp.linux.org.uk>
Date:	Sun, 11 Feb 2007 08:21:59 +0000
From:	Al Viro <viro@....linux.org.uk>
To:	Christoph Hellwig <hch@...radead.org>,
	Tejun Heo <htejun@...il.com>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Jeff Garzik <jgarzik@...ox.com>, linux-kernel@...r.kernel.org,
	linux-s390@...r.kernel.org
Subject: Re: [patch] linux/io.h: forward declare struct pci_dev

On Sun, Feb 11, 2007 at 07:10:47AM +0000, Christoph Hellwig wrote:
> On Sun, Feb 11, 2007 at 06:34:31AM +0000, Al Viro wrote:
> > +config NO_IOPORT
> > +	bool
> > +	default n
> 
> please make this IOPORT.  config symbols with an implicit negation
> are quite horrible for the brain to understand.

Take a look at lib/Kconfig.  And see HAS_IOPORT there.

The reason for doing it that way: majority of targets has that stuff
already.  Even more should have it eventually.  IOW, the default should
be positive.  Modified in arch/*/Kconfig of targets where it doesn't
work.  Which is exactly what's done here.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ