linux-kernel - [PATCH 2.6.20 06/10] nfnetlink_log: micro-optimization: don't modify destroyed instance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20070212003941.GG8262@rere.qmqm.pl>
Date:	Mon, 12 Feb 2007 01:39:41 +0100
From:	Michał Mirosław <mirq-linux@...e.qmqm.pl>
To:	netfilter-devel@...ts.netfilter.org
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH 2.6.20 06/10] nfnetlink_log: micro-optimization: don't modify destroyed instance

Simple micro-optimization: Don't change any options if the instance is
being destroyed.

Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>

--- linux-2.6.20/net/netfilter/nfnetlink_log.c.4	2007-02-11 20:46:26.000000000 +0100
+++ linux-2.6.20/net/netfilter/nfnetlink_log.c	2007-02-11 22:24:56.000000000 +0100
@@ -829,7 +829,8 @@ nfulnl_recv_config(struct sock *ctnl, st
 			}
 
 			instance_destroy(inst);
-			break;
+			/* no point in changing anything in destroyed instance */
+			goto out_put;
 		case NFULNL_CFG_CMD_PF_BIND:
 			UDEBUG("registering log handler for pf=%u\n", pf);
 			ret = nf_log_register(pf, &nfulnl_logger);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/