[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <45D0307C.1040302@vmware.com>
Date: Mon, 12 Feb 2007 01:16:44 -0800
From: Zachary Amsden <zach@...are.com>
To: Rusty Russell <rusty@...tcorp.com.au>
CC: Andrew Morton <akpm@...ux-foundation.org>,
lkml - Kernel Mailing List <linux-kernel@...r.kernel.org>,
virtualization <virtualization@...ts.osdl.org>,
Paul Mackerras <paulus@...ba.org>
Subject: Re: [PATCH 5/7] cleanup: Rename cpu_gdt_descr and remove extern declaration
from smpboot.c
Rusty Russell wrote:
> When I implemented the DECLARE_PER_CPU(var) macros, I was careful that
> people couldn't use "var" in a non-percpu context, by prepending
> percpu__. I never considered that this would allow them to overload
> the same name for a per-cpu and a non-percpu variable.
>
> It is only one of many horrors in the i386 boot code, but let's rename
> the non-perpcu cpu_gdt_descr to early_gdt_descr (not boot_gdt_descr,
> that's something else...)
>
Finally, someone not just noticed, but fixed it! Thank you Rusty. Was
on my todo list, but never bubbled up.
Acked-by: Zachary Amsden <zach@...are.com>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists