linux-kernel - Re: [PATCH 2.6.20] sound/pci/ca0106: add device attribute to ca0106 devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h64a7mqul.wl%tiwai@suse.de>
Date:	Mon, 12 Feb 2007 14:45:54 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Wouter Paesen <wouter@...garoot.net>
Cc:	Jaroslav Kysela <perex@...e.cz>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.20] sound/pci/ca0106: add device attribute to ca0106 devices

At Fri, 9 Feb 2007 17:52:11 +0100,
Wouter Paesen wrote:
> 
> 
> The ca0106 driver does not install a reference to the pci
> device in it's __devinit function.   This will result in a 
> missing "device" attribute on the sound devices associated with
> this card, which makes hal/libhal ignore the card.
> 
> Signed-off-by: Wouter Paesen <wouter@...garoot.net>

Thanks, it's already fixed in the latest git tree.


Takashi

> --
> 
> --- linux-2.6.20/sound/pci/ca0106/ca0106_main.c.orig	2007-02-04 19:44:54.000000000 +0100
> +++ linux-2.6.20/sound/pci/ca0106/ca0106_main.c	        2007-02-09 17:20:37.000000000 +0100
> @@ -1455,6 +1455,8 @@ static int __devinit snd_ca0106_create(i
>  		snd_ca0106_free(chip);
>  		return err;
>  	}
> +
> +	snd_card_set_dev(card, &pci->dev);
>  	*rchip = chip;
>  	return 0;
>  }
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/