linux-kernel - [PATCH] Standardize on "depends on" in Kconfig files.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0702121635001.29808@CPE00045a9c397f-CM001225dbafb6>
Date:	Mon, 12 Feb 2007 16:41:05 -0500 (EST)
From:	"Robert P. J. Day" <rpjday@...dspring.com>
To:	Linux kernel mailing list <linux-kernel@...r.kernel.org>
cc:	Roman Zippel <zippel@...ux-m68k.org>
Subject: [PATCH] Standardize on "depends on" in Kconfig files.


  Standardize on "depends on" in Kconfig files, and drop support for
the alternative forms of "depends" or "requires".

Signed-off-by: Robert P. J. Day <rpjday@...dspring.com>

---

  there was a consensus to standardize exclusively on the qualifier
"depends on" in Kconfig files, and i've had a patch in the system for
quite some time to take care of the three remaining files.  but not
only are those files still using the old form of "depends", now
there's another file that's *added* a few more instances.  grrrr.

  what about just dropping support in the kbuild structure?  *that*
would make sure things got cleaned up in a hurry.  this isn't perl --
it's not necessarily good that there's more than one way to do it.


 arch/arm/Kconfig         |    2 +-
 arch/arm/mm/Kconfig      |    2 +-
 arch/v850/Kconfig        |    2 +-
 sound/soc/codecs/Kconfig |    8 ++++----
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 5c79519..77d062e 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -405,7 +405,7 @@ source arch/arm/mm/Kconfig

 config IWMMXT
 	bool "Enable iWMMXt support"
-	depends CPU_XSCALE || CPU_XSC3
+	depends on CPU_XSCALE || CPU_XSC3
 	default y if PXA27x
 	help
 	  Enable support for iWMMXt context switching at run time if
diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig
index aade2f7..3c2f979 100644
--- a/arch/arm/mm/Kconfig
+++ b/arch/arm/mm/Kconfig
@@ -525,7 +525,7 @@ config CPU_BIG_ENDIAN
 	  of your chipset/board/processor.

 config CPU_HIGH_VECTOR
-	depends !MMU && CPU_CP15 && !CPU_ARM740T
+	depends on !MMU && CPU_CP15 && !CPU_ARM740T
 	bool "Select the High exception vector"
 	default n
 	help
diff --git a/arch/v850/Kconfig b/arch/v850/Kconfig
index dbfab8f..50ccc7f 100644
--- a/arch/v850/Kconfig
+++ b/arch/v850/Kconfig
@@ -217,7 +217,7 @@ menu "Processor type and features"
    # Some platforms pre-zero memory, in which case the kernel doesn't need to
    config ZERO_BSS
    	  bool
-	  depends !V850E2_SIM85E2C
+	  depends on !V850E2_SIM85E2C
 	  default y

    # The crappy-ass zone allocator requires that the start of allocatable
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 78ac268..ec2a278 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -1,15 +1,15 @@
 config SND_SOC_AC97_CODEC
 	tristate
-	depends SND_SOC
+	depends on SND_SOC

 config SND_SOC_WM8731
 	tristate
-	depends SND_SOC
+	depends on SND_SOC

 config SND_SOC_WM8750
 	tristate
-	depends SND_SOC
+	depends on SND_SOC

 config SND_SOC_WM9712
 	tristate
-	depends SND_SOC
+	depends on SND_SOC

-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/