| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 13 Feb 2007 10:44:32 +1100 From: NeilBrown <neilb@...e.de> To: Andrew Morton <akpm@...ux-foundation.org> Cc: nfs@...ts.sourceforge.net, linux-kernel@...r.kernel.org Subject: [PATCH 006 of 9] knfsd: nfsd4: fix error return on unsupported acl From: J. Bruce Fields <bfields@...i.umich.edu> We should be returning ATTRNOTSUPP, not NOTSUPP, when acls are unsupported. Also fix a comment. Signed-off-by: "J. Bruce Fields" <bfields@...i.umich.edu> Signed-off-by: Neil Brown <neilb@...e.de> ### Diffstat output ./fs/nfsd/nfs4xdr.c | 2 +- ./fs/nfsd/vfs.c | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff .prev/fs/nfsd/nfs4xdr.c ./fs/nfsd/nfs4xdr.c --- .prev/fs/nfsd/nfs4xdr.c 2007-02-13 10:36:40.000000000 +1100 +++ ./fs/nfsd/nfs4xdr.c 2007-02-13 10:37:00.000000000 +1100 @@ -253,7 +253,7 @@ nfsd4_decode_fattr(struct nfsd4_compound return status; /* - * According to spec, unsupported attributes return ERR_NOTSUPP; + * According to spec, unsupported attributes return ERR_ATTRNOTSUPP; * read-only attributes return ERR_INVAL. */ if ((bmval[0] & ~NFSD_SUPPORTED_ATTRS_WORD0) || (bmval[1] & ~NFSD_SUPPORTED_ATTRS_WORD1)) diff .prev/fs/nfsd/vfs.c ./fs/nfsd/vfs.c --- .prev/fs/nfsd/vfs.c 2007-02-13 09:50:24.000000000 +1100 +++ ./fs/nfsd/vfs.c 2007-02-13 10:37:00.000000000 +1100 @@ -466,7 +466,10 @@ out: posix_acl_release(dpacl); return (error); out_nfserr: - error = nfserrno(host_error); + if (host_error == -EOPNOTSUPP) + error = nfserr_attrnotsupp; + else + error = nfserrno(host_error); goto out; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists