linux-kernel - Re: [GIT] NFS client updates for 2.6.20

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1171363432.24923.7.camel@twins>
Date:	Tue, 13 Feb 2007 11:43:52 +0100
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Trond Myklebust <Trond.Myklebust@...app.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	nfs <nfs@...ts.sourceforge.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [GIT] NFS client updates for 2.6.20

On Mon, 2007-02-12 at 23:39 -0800, Trond Myklebust wrote:

> commit 7c85d9007d05436e71d2b805b96c1e36a8193bd4
> Author: Trond Myklebust <Trond.Myklebust@...app.com>
> Date:   Wed Dec 13 15:23:48 2006 -0500
> 
>     NFS: Fixup some outdated comments...
>     
>     Signed-off-by: Trond Myklebust <Trond.Myklebust@...app.com>

A few new comments would be appreciated :-)

> commit 02241bc47e8961768de83d855accd0dcad1df045
> Author: Trond Myklebust <Trond.Myklebust@...app.com>
> Date:   Sat Jan 13 02:28:07 2007 -0500
> 
>     NFS: Ensure that ->writepage() uses flush_stable() when reclaiming pages
>     
>     Signed-off-by: Trond Myklebust <Trond.Myklebust@...app.com>

That patch seems to make all ->writepage() calls use stable storage.
Of course, given that there are no other ->writepage() calls this
works out.

I've been using this:
---

Subject: nfs: only use stable storage for swap

unstable writes don't make sense for swap pages.

Signed-off-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc: Trond Myklebust <trond.myklebust@....uio.no>
---
 fs/nfs/write.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6-git/fs/nfs/write.c
===================================================================
--- linux-2.6-git.orig/fs/nfs/write.c	2007-01-09 11:38:25.000000000 +0100
+++ linux-2.6-git/fs/nfs/write.c	2007-01-09 13:40:34.000000000 +0100
@@ -231,7 +231,7 @@ static int nfs_writepage_setup(struct nf
 static int wb_priority(struct writeback_control *wbc)
 {
 	if (wbc->for_reclaim)
-		return FLUSH_HIGHPRI;
+		return FLUSH_HIGHPRI|FLUSH_STABLE;
 	if (wbc->for_kupdate)
 		return FLUSH_LOWPRI;
 	return 0;


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/