[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87fy99n6mf.fsf@javad.com>
Date: Tue, 13 Feb 2007 23:29:44 +0300
From: Sergei Organov <osv@...ad.com>
To: "Pekka Enberg" <penberg@...helsinki.fi>
Cc: "Linus Torvalds" <torvalds@...ux-foundation.org>,
J.A. MagallÃón
<jamagallon@....com>, "Jan Engelhardt" <jengelh@...ux01.gwdg.de>,
"Jeff Garzik" <jeff@...zik.org>,
"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
"Andrew Morton" <akpm@...ux-foundation.org>
Subject: Re: somebody dropped a (warning) bomb
"Pekka Enberg" <penberg@...helsinki.fi> writes:
> On 2/13/07, Sergei Organov <osv@...ad.com> wrote:
>> With almost any warning out there one makes more or less efforts to
>> suppress the warning where it gives false positives, isn't it?
>
> Yes, as long it's the _compiler_ that's doing the effort.
> You shouldn't need to annotate the source just to make the compiler
> shut up.
Sorry, what do you do with "variable 'xxx' might be used uninitialized"
warning when it's false? Turn it off? Annotate the source? Assign fake
initialization value? Change the compiler so that it does "the effort"
for you? Never encountered false positive from this warning?
> Once the compiler starts issuing enough false positives, it's
> time to turn off that warning completely.
Yes, I don't argue that. I said "otherwise the warning is more or less
sucks", and then it's up to programmers to decide if it's enough sucks
to be turned off. The decision depends on the importance of its true
positives then. Only if warning never has true positives it is
unconditional, total, unhelpful crap, -- that was my point.
> Therefore, the only sane strategy for a warning is to aim for zero
> false positives.
Sure. But unfortunately this in an unreachable aim in most cases.
-- Sergei.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists