linux-kernel - Re: [PATCH 5/8] lguest: trivial guest network driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1171494009.19842.185.camel@localhost.localdomain>
Date:	Thu, 15 Feb 2007 10:00:09 +1100
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	lkml - Kernel Mailing List <linux-kernel@...r.kernel.org>,
	virtualization <virtualization@...ts.osdl.org>,
	jgarzik <jgarzik@...ox.com>
Subject: Re: [PATCH 5/8] lguest: trivial guest network driver

On Thu, 2007-02-15 at 00:57 +1100, Herbert Xu wrote:
> On Wed, Feb 14, 2007 at 03:47:55PM +1100, Rusty Russell wrote:
> > 
> > It's also used to generate dma structs for outgoing packets.  In that
> > case, skb_headlen() == 0:
> 
> I see, in that case you're guaranteed to have no fragments.
> Still it feels a bit weird to have a length field that only
> applies to the header part.

Indeed.  In future if I want to create fragmented skbs for receive
(large MTU support), I would actually set skb->len and skb->datalen and
then could avoid the extra argument.

Cheers,
Rusty.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/