linux-kernel - Re: Is this bug too obvious?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0702132000220.20138@iabervon.org>
Date:	Tue, 13 Feb 2007 20:06:48 -0500 (EST)
From:	Daniel Barkalow <barkalow@...ervon.org>
To:	Chuck Ebbert <cebbert@...hat.com>
cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Dave Jones <davej@...hat.com>
Subject: Re: Is this bug too obvious?

On Tue, 13 Feb 2007, Chuck Ebbert wrote:

> drivers/usb/net/usbnet.c:
> 
> int
> usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod)
> {
>         struct usbnet                   *dev;
>         struct net_device               *net;
>         struct usb_host_interface       *interface;
>         struct driver_info              *info;
>         struct usb_device               *xdev;
>         int                             status;
> 
> 	...
> 
>         net = alloc_etherdev(sizeof(*dev));
>                                     ^^^^
> 	                            *net ???

No, alloc_etherdev takes the size of the private data, which, in this 
case, is *dev.

	-Daniel
*This .sig left intentionally blank*
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/