linux-kernel - Re: [patch 3/4] ipmi: add pci remove handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070215022745.648ab8cb.akpm@linux-foundation.org>
Date:	Thu, 15 Feb 2007 02:27:45 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	minyard@....org
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [patch 3/4] ipmi: add pci remove handling

On Wed, 14 Feb 2007 14:06:24 -0600 Corey Minyard <minyard@....org> wrote:

> Add pci_remove handling to the driver, so it will clean up if
> the device is hot-removed.
> 
> Signed-off-by: Corey Minyard <minyard@....org>
> 
> Index: linux-2.6.19/drivers/char/ipmi/ipmi_si_intf.c
> ===================================================================
> --- linux-2.6.19.orig/drivers/char/ipmi/ipmi_si_intf.c
> +++ linux-2.6.19/drivers/char/ipmi/ipmi_si_intf.c
> @@ -2191,12 +2191,15 @@ static int __devinit ipmi_pci_probe(stru
>  		info->irq_setup = std_irq_setup;
>  
>  	info->dev = &pdev->dev;
> +	pdev->dev->driver_data = info;
>  
>  	return try_smi_init(info);
>  }
>  
>  static void __devexit ipmi_pci_remove(struct pci_dev *pdev)
>  {
> +	struct smi_info *info = pdev->dev->driver_data;
> +	cleanup_one_si(info);
>  }

drivers/char/ipmi/ipmi_si_intf.c: In function 'ipmi_pci_probe':
drivers/char/ipmi/ipmi_si_intf.c:2192: error: invalid type argument of '->'
drivers/char/ipmi/ipmi_si_intf.c: In function 'ipmi_pci_remove':
drivers/char/ipmi/ipmi_si_intf.c:2199: error: invalid type argument of '->'

Judging from the patch headers you were working against 2.6.19, which is
most optimistic.  Please always prepare and test patches against the
latest kernel.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/