linux-kernel - Re: [PATCH 9/11] Panic delay fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Feb 2007 08:35:42 -0500
From:	"Dmitry Torokhov" <dmitry.torokhov@...il.com>
To:	"Rusty Russell" <rusty@...tcorp.com.au>
Cc:	"Zachary Amsden" <zach@...are.com>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	"Andrew Morton" <akp=m@...l.org>, "Andi Kleen" <ak@....de>,
	"Jeremy Fitzhardinge" <jeremy@...p.org>,
	"Chris Wright" <chrisw@...s-sol.org>,
	Alan <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH 9/11] Panic delay fix

On 2/14/07, Rusty Russell <rusty@...tcorp.com.au> wrote:
> On Mon, 2007-02-05 at 19:53 -0800, Zachary Amsden wrote:
> > Failure to use real-time delay here causes the keyboard to become demonically
> > possessed in the event of a kernel crash, with wildly blinking lights and
> > unpredictable behavior.  This has resulted in several injuries.
>
> The problem is the normal one when we introduce a new concept into the
> kernel; there are two kinds of udelay, and they've been conflated.  The
> most common case is a delay for real hardware devices; this can be
> eliminated for paravirtualization.  The other cases, the tiny minority,
> are visible delays (keyboard leds), not knowing if they're necessary
> (very early boot), and async events (other CPUs coming up): ie.
> everything else.
>

Just for the record - I believe that i8042 is fine as is now. The only
place where real delay needs to be enforced is panic.c - it should
call panic blink routine once every 1 ms.

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/