linux-kernel - Re: [PATCH] HIL: fix improper call of release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200702151954.33474.deller@gmx.de>
Date:	Thu, 15 Feb 2007 19:54:33 +0100
From:	Helge Deller <deller@....de>
To:	"Cyrill V. Gorcunov" <gorcunov@...il.com>
Cc:	linux-kernel-list <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH] HIL: fix improper call of release_region

Hi Cyrill,

please include the "err1" label as well inside the #if / #endif clause.
err1 is used only when CONFIG_HP300 is defined and in the parisc-case you currently get an unused label warning...

Helge

On Thursday 15 February 2007, Cyrill V. Gorcunov wrote:
> Thist patch prevents from improper call of release_region
> if the code has been compiled without CONFIG_HP300 support.
> 
> Signed-off-by: Cyrill V. Gorcunov <gorcunov@...il.com>
> 
> ---
> 
>  drivers/input/keyboard/hilkbd.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/input/keyboard/hilkbd.c b/drivers/input/keyboard/hilkbd.c
> index 255a6ec..c3c0da3 100644
> --- a/drivers/input/keyboard/hilkbd.c
> +++ b/drivers/input/keyboard/hilkbd.c
> @@ -294,7 +294,9 @@ err3:
>  	disable_irq(HIL_IRQ);
>  	free_irq(HIL_IRQ, hil_dev.dev_id);
>  err2:
> +#if defined(CONFIG_HP300)
>  	release_region(HILBASE + HIL_DATA, 2);
> +#endif
>  err1:
>  	input_free_device(hil_dev.dev);
>  	hil_dev.dev = NULL;
> 


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/