linux-kernel - RE: [PATCH 3/6] scsi: megaraid_sas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <0631C836DBF79F42B5A60C8C8D4E822992131B@NAMAIL2.ad.lsil.com>
Date:	Thu, 15 Feb 2007 16:44:00 -0700
From:	"Patro, Sumant" <Sumant.Patro@....com>
To:	"Richard Knutsson" <ricknu-0@...dent.ltu.se>
Cc:	<James.Bottomley@...elEye.com>, <akpm@...l.org>,
	<linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	"Kolli, Neela" <Neela.Kolli@....com>, "Yang, Bo" <Bo.Yang@....com>
Subject: RE: [PATCH 3/6] scsi: megaraid_sas - throttle io if FW is busy

Yes I can make it boolean. 
Will change it in a future patch submission.

Thanks,
Sumant

-----Original Message-----
From: Richard Knutsson [mailto:ricknu-0@...dent.ltu.se] 
Sent: Thursday, February 15, 2007 12:10 AM
To: Patro, Sumant
Cc: James.Bottomley@...elEye.com; akpm@...l.org;
linux-scsi@...r.kernel.org; linux-kernel@...r.kernel.org; Kolli, Neela;
Yang, Bo; Patro, Sumant
Subject: Re: [PATCH 3/6] scsi: megaraid_sas - throttle io if FW is busy

Sumant Patro wrote:
> Checks added in megasas_queue_command to know if FW is able to process

> commands within the timeout period. If number of retries is 2 or more,

> the driver stops sending cmd to FW. IO is resumed when pending cmd 
> count reduces to 16 or 10 seconds has elapsed from the time cmds were 
> last sent to FW.
>
> Signed-off-by: Sumant Patro <sumant.patro@....com>
> ---
>
>  drivers/scsi/megaraid/megaraid_sas.c |   27 +++++++++++++++++++++++++
>  drivers/scsi/megaraid/megaraid_sas.h |    3 ++
>  2 files changed, 30 insertions(+)
>
>   
[snip]
> diff -uprN linux-feb13-new-p2/drivers/scsi/megaraid/megaraid_sas.h
linux-feb13-new-p3/drivers/scsi/megaraid/megaraid_sas.h
> --- linux-feb13-new-p2/drivers/scsi/megaraid/megaraid_sas.h
2007-02-13 07:22:40.000000000 -0800
> +++ linux-feb13-new-p3/drivers/scsi/megaraid/megaraid_sas.h
2007-02-13 11:37:09.000000000 -0800
> @@ -1102,6 +1102,9 @@ struct megasas_instance {
>  	atomic_t fw_outstanding;
>  	u32 hw_crit_error;
>  
> +	u8 is_busy;
>   
Why not "bool is_busy:8;"? It obviously is a boolean. I would also think
false/true would be more descriptive then 0/1.

Richard Knutsson

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/