linux-kernel - Re: [patch 2.6.20-git] remove modpost false warnings on ARM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070216082648.GA11771@uranus.ravnborg.org>
Date:	Fri, 16 Feb 2007 09:26:48 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	David Brownell <david-b@...bell.net>
Cc:	Linux Kernel list <linux-kernel@...r.kernel.org>,
	Andi Kleen <ak@...e.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	ebiederm@...ssion.com, kai@...maschewski.name,
	Russell King <rmk@....linux.org.uk>, rusty@...tcorp.com.au
Subject: Re: [patch 2.6.20-git] remove modpost false warnings on ARM

On Thu, Feb 15, 2007 at 07:10:45PM -0800, David Brownell wrote:
> This patch stops "modpost" from issuing erroneous modpost warnings on ARM
> builds, which it's been doing since since maybe last summer.  A canonical
> example would be driver method table entries:
> 
>   WARNING: <path> - Section mismatch: reference to .exit.text:<name>_remove
> 	from .data after '$d' (at offset 0x4)
> 
> That "$d" symbol is generated by tools conformant with ARM ABI specs; in
> this case it's a symbol **in the middle of** a "<name>_driver" struct.
> 
> The erroneous warnings appear to be issued because "modpost" whitelists
> references from "<name>_driver" data into init and exit sections ... but
> doesn't know should also include those "$d" mapping symbols, which are
> not otherwise associated with "<name>_driver" symbols.
> 
> This patch prevents the modpost symbol lookup code from ever returning
> those mapping symbols, so it will return a whitelisted symbol instead.
> Then things work as expected.
> 
> Now to revert various code-bloating "fixes" that got merged because of
> this modpost bug....
> 
> Signed-off-by: David Brownell <dbrownell@...rs.sourceforge.net>
Acked-by: Sam Ravnborg <sam@...nborg.org>

And if I get my dev machine operational before akpm merges this I
will take care of having it merged.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/