linux-kernel - Re: [patch 07/21] Xen-paravirt: remove ctor for pgd cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84144f020702160039y11fb1f4dl7b77d4358cc189ee@mail.gmail.com>
Date:	Fri, 16 Feb 2007 10:39:33 +0200
From:	"Pekka Enberg" <penberg@...helsinki.fi>
To:	"Jeremy Fitzhardinge" <jeremy@...p.org>
Cc:	"Andi Kleen" <ak@....de>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, virtualization@...ts.osdl.org,
	xen-devel@...ts.xensource.com,
	"Chris Wright" <chrisw@...s-sol.org>,
	"Zachary Amsden" <zach@...are.com>
Subject: Re: [patch 07/21] Xen-paravirt: remove ctor for pgd cache

On 2/16/07, Jeremy Fitzhardinge <jeremy@...p.org> wrote:
> Remove the ctor for the pgd cache.  There's no point in having the
> cache machinery do this via an indirect call when all pgd are freed in
> the one place anyway.

The reason we have slab constructors and destructors is to _avoid_
reinitializing every time we allocate an object. AFAICT your changing
the code now to do _more_ work than before, so is there some other
reason why you want to do this than avoiding an indirect call?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/