linux-kernel - RE: [PATCH 3/5] scsi: megaraid_sas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1171648254.3443.34.camel@mulgrave.il.steeleye.com>
Date:	Fri, 16 Feb 2007 11:50:54 -0600
From:	James Bottomley <James.Bottomley@...elEye.com>
To:	"Patro, Sumant" <Sumant.Patro@....com>
Cc:	akpm@...l.org, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org, "Kolli, Neela" <Neela.Kolli@....com>,
	"Yang, Bo" <Bo.Yang@....com>
Subject: RE: [PATCH 3/5] scsi: megaraid_sas - throttle io if FW is busy

On Thu, 2007-02-15 at 19:53 -0700, Patro, Sumant wrote:
> Hello James,
> 
> 	I re-submitted the patch yesterday with the "space" issue fixed
> (adhering to coding guideline).
> 
> 	I will check for alternative to calculate the time driver have
> been sending host busy to OS. Will check with time_before() as you have
> suggested.
> 
> 	Throttling from megasas_generic_reset() handler did not help.
> megaraid does not have feature to abort cmds. So, in the generic reset
> routine, the driver just waits for cmd completion by FW. These timed-out
> cmds gets retried by mid-layer with "retries" incremented by 1.
> Eventually we see retries equals max_allowed followed by SCSI error with
> "DRIVER_TIMEOUT".

That's rather what worries me.  When the error handler activates (which
it will on the first timeout), it waits for all commands to complete or
time out before running.  Your reset handler does nothing other than
wait for the firmware to complete the commands (now uselessly), so we
now wait for the entire firmware command queue to drain, then you tell
the mid layer everything is OK, so it loads you up again with all the
commands plus a few test unit readies for good measure, then you
throttle.

You really want to catch the device going into this condition and do
something at that point ... prime candidate would be lowering the
can_queue depth to get fewer commands transiting the firmware.

James

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/