linux-kernel - Re: [PATCH] sparse chokes on arch/i386/kernel/i8253.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070215173108.0fbd56ea.akpm@linux-foundation.org>
Date:	Thu, 15 Feb 2007 17:31:08 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
Cc:	Tilman Schmidt <tilman@...p.cc>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sparse chokes on arch/i386/kernel/i8253.c

On Thu, 15 Feb 2007 19:58:04 -0500
Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca> wrote:

> > > 
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -309,7 +309,8 @@ AFLAGS_KERNEL	=
> > >  LINUXINCLUDE    := -Iinclude \
> > >                     $(if $(KBUILD_SRC),-Iinclude2 -I$(srctree)/include) \
> > >  		   -include include/linux/autoconf.h \
> > > -		   -include linux/marker.h
> > > +		   -include \
> > > +		   	$(if $(KBUILD_SRC),$(srctree)/)include/linux/marker.h
> > >  
> > >  CPPFLAGS        := -D__KERNEL__ $(LINUXINCLUDE)
> > 
> > But what is so magical about marker.h to justify special-case treatment at the
> > kbuid level?
> 
> Idealistically speaking, nothing. It is however much easier to maintain
> an external set of patches introducing markers within the kernel tree :
> most of the rejects between kernel version comes from new includes that
> comes in the way.
> 
> So this is there more by convenience than requirement.

No sale.  Let's kill it, please ;)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/