linux-kernel - Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070216204336.GB4641@enneenne.com>
Date:	Fri, 16 Feb 2007 21:43:36 +0100
From:	Rodolfo Giometti <giometti@...eenne.com>
To:	linux-kernel@...r.kernel.org, linuxpps@...enneenne.com
Subject: Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

On Fri, Feb 16, 2007 at 07:12:08PM +0000, Russell King wrote:
> 
> Yuck.  Please.  No.  Doing it this way means you have to modify every
> single serial driver out there which is a mamouth task.
> 
> >  			uart_handle_dcd_change(&up->port, status & UART_MSR_DCD);
> 
> Did you not look to see what's in this helper?  You'll find within here
> the following code:
> 
> #ifdef CONFIG_HARD_PPS
>         if ((port->flags & UPF_HARDPPS_CD) && status)
>                 hardpps();
> #endif
> 
> which should've been a big sign lit up in bright lights in Times Square
> pointing you towards the right place to put your code.

Ok.

> Why not continue to leave it as a decision of the administrator - if
> you want ports to default to having PPS support enabled, change all
> the registration to set UPF_HARDPPS_CD.  But leave the admin with
> the ability to disable it.

Ok.

> This means that PPS support is not available for any port which wasn't
> autoprobed at device discovery time.  That seems quite restrictive.

How I can force probing for a specified uart port?

> Maybe it needs to be coupled with the setting/clearing of UPF_HARDPPS_CD ?

What do you think about? I should enable the PPS support only if the
userland sets the UPF_HARDPPS_CD flag?

Thanks for your comments,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti@...eenne.com
Linux Device Driver                             giometti@...dd.com
Embedded Systems                     		giometti@...ux.it
UNIX programming                     phone:     +39 349 2432127
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/