linux-kernel - Re: [PATCH] Linux Kernel Markers Documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070216035603.GB16075@Krystal>
Date:	Thu, 15 Feb 2007 22:56:03 -0500
From:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Christoph Hellwig <hch@...radead.org>,
	Ingo Molnar <mingo@...hat.com>, systemtap@...rces.redhat.com,
	ltt-dev@...fik.org
Subject: Re: [PATCH] Linux Kernel Markers Documentation

Hi Randy,

* Randy Dunlap (randy.dunlap@...cle.com) wrote:
> so is the MARK() supposed to be:
>   MARK(subsystem, event, ...
> 
> Please make the 2 doc. lines above match the parameters...
> or the parameters match the text.
> 

Fixing the paragraph below.

> > +- "%d %s %p[struct task_struct]" is the formatted string for (printk-style).
> > +- someint is an integer.
> > +- somestring is a char pointer.
> > +- current is a pointer to a struct task_struct.
> > +
> > +The expression %p[struct task_struct] is a suggested marker definition
> > +standard that could eventually be used for pointer type checking in
> > +sparse. The brackets contain the type to which the pointer refer.
>                                                               refers.
> 
> > +
> > +#define SUBSYSTEM_EVENT_FORMAT "%d %s %p[struct task_struct]"
> 
> Is SUBSYSTEM_EVENT_FORMAT used implicitly below?  or elsewhere?
> 

Yes, error follows.

> > +void probe_subsystem_event(const char *format, ...)
> > +{
> > +	va_list ap;
> > +	/* Declare args */
> > +	unsigned int value;
> > +	const char *mystr;
> > +	struct task_struct *task;
> > +
> > +	/* Assign args */
> > +	va_start(ap, format);
> > +	value = va_arg(ap, typeof(value));
> > +	mystr = va_arg(ap, typeof(mystr));
> > +	task = va_arg(ap, typeof(task));
> > +
> > +	/* Call tracer */
> > +	trace_subsystem_event(value, mystr, task);
> > +
> > +	/* Or call printk */
> > +	vprintk(format, ap);
> > +
> > +	/* or count, check rights... */
> > +	
> > +	va_end(ap);
> > +}
> > +
> > +static int __init probe_init(void)
> > +{
> > +	int result;
> > +	result = marker_set_probe("subsystem_event",
> > +			FS_CLOSE_FORMAT,
> > +			probe_fs_close);
> 
> Do FS_CLOSE_FORMAT and probe_fs_close() need to be defined here?
> I.e., is this a complete example?
> 

should be SUBSYSTEM_EVENT_FORMAT. Will fix, thanks.

Regards,

Mathieu

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Candidate, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/