linux-kernel - Re: [linux-usb-devel] OOM and USB, latest Linux 2.6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45D7462D.6080700@monatomic.org>
Date:	Sat, 17 Feb 2007 20:15:09 +0200
From:	Dan Aloni <da-x@...atomic.org>
To:	Alan Stern <stern@...land.harvard.edu>
CC:	Linux Kernel List <linux-kernel@...r.kernel.org>,
	linux-usb-devel-bounces@...ts.sourceforge.net
Subject: Re: [linux-usb-devel] OOM and USB, latest Linux 2.6

Alan Stern wrote:
> On Sat, 17 Feb 2007, Dan Aloni wrote:
>
>   
>> Hello,
>>
>> Is it possible that OOM isn't handled very well if say, my entire
>> file system structure is on a USB storage device?
>>
>> I'm not an expert on this particular matter but I'm pretty sure 
>> that I noticed GFP_KERNEL allocation being done on the write-out 
>> path in the usb-storage kernel thread, leading to a deadlock 
>> during OOM.
>>     
>
> Can you be any more specific than that?  usb-storage should use only 
> GFP_NOIO in its I/O paths.
>
>
>   
You are right, I looked over this state with kdb, and usb-storage
waited in usb_stor_bulk_transfer_sg, which does pass GFP_NOIO
at this scenario.

It looked suspicious though, because OOM handling was invoked
from many processes, and it didn't print about any process being
killed and it didn't complain about no processes to kill either.

(I'll look more into this, perhaps there's an OOM handling bug)

BTW, soft-rebooting the machine in that state made the USB
storage device (LEXAR,  JD LIGHTNING II) inaccessible to the
BIOS. I had to do a complete power cycle in order or the BIOS
to see it again.

-- 
Dan Aloni
XIV LTD, http://www.xivstorage.com
da-x (at) monatomic.org, dan (at) xiv.co.il

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/