linux-kernel - Re: [PATCH] x86: mtrr range check correction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45D8C620.2000009@redhat.com>
Date:	Sun, 18 Feb 2007 16:33:20 -0500
From:	Chuck Ebbert <cebbert@...hat.com>
To:	Jan Beulich <jbeulich@...ell.com>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: mtrr range check correction

Jan Beulich wrote:
> Whether a region is below 1Mb is determined by its start rather than
> its end.
> 
> This hunk got erroneously dropped from a previous patch.
> 
> Signed-off-by: Jan Beulich <jbeulich@...ell.com>
> 
> --- linux-2.6.20/arch/i386/kernel/cpu/mtrr/generic.c	2007-02-04 19:44:54.000000000 +0100
> +++ 2.6.20-x86-mtrr-range-check/arch/i386/kernel/cpu/mtrr/generic.c	2007-02-09 10:17:26.000000000 +0100
> @@ -428,7 +428,7 @@ int generic_validate_add_page(unsigned l
>  		}
>  	}
>  
> -	if (base + size < 0x100) {
> +	if (base < 0x100) {
>  		printk(KERN_WARNING "mtrr: cannot set region below 1 MiB (0x%lx000,0x%lx000)\n",
>  		       base, size);
>  		return -EINVAL;
> 

What about wraparound?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/