linux-kernel - Re: [mmc] incorrect behavior on resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070218065318.GA14251@flint.arm.linux.org.uk>
Date:	Sun, 18 Feb 2007 06:53:18 +0000
From:	Russell King <rmk+lkml@....linux.org.uk>
To:	Alex Dubov <oakad@...oo.com>
Cc:	Pavel Machek <pavel@....cz>, Pierre Ossman <drzeus-mmc@...eus.cx>,
	Greg KH <greg@...ah.com>, linux-kernel@...r.kernel.org
Subject: Re: [mmc] incorrect behavior on resume

On Sat, Feb 17, 2007 at 05:46:35PM -0800, Alex Dubov wrote:
> The problem here is that mmc_block's device is a child of real device
> (tifm_dev here), so it gets resumed right after it.

The host driver is supposed to call mmc_resume_host from it's resume
callback.  This should be called before the child's resume callback.

> However, it correct functioning depends on mmc_core, which must be
> manually resumed (mmc_resume_host). Therefore, I think this is
> purely mmc's problem.

I don't see that - as I say above, the correct sequence is:

 - host device resume
     - calls mmc_resume_host()
 - child's device resume (mmc_blk_resume)
     - mmc_queue_resume()

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/