[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <84144f020702190313m38b670eew204a5017e777851e@mail.gmail.com>
Date: Mon, 19 Feb 2007 13:13:23 +0200
From: "Pekka Enberg" <penberg@...helsinki.fi>
To: "Artem Bityutskiy" <dedekind@...radead.org>
Cc: "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
"Christoph Hellwig" <hch@...radead.org>,
"Frank Haverkamp" <haver@...t.ibm.com>,
"Thomas Gleixner" <tglx@...utronix.de>,
"David Woodhouse" <dwmw2@...radead.org>,
"Josh Boyer" <jwboyer@...ux.vnet.ibm.com>
Subject: Re: [PATCH 12/44 take 2] [UBI] allocation unit implementation
On 2/17/07, Artem Bityutskiy <dedekind@...radead.org> wrote:
> +void *ubi_kzalloc(size_t size)
> +{
> + void *ret;
> +
> + ret = kzalloc(size, GFP_KERNEL);
> + if (unlikely(!ret)) {
> + ubi_err("cannot allocate %zd bytes", size);
> + dump_stack();
> + return NULL;
> + }
> +
> + return ret;
> +}
[snip, snip]
NAK. Please drop all of these utterly pointless kmalloc() and
kmem_cache_alloc() wrappers.
Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists