linux-kernel - Re: O2micro smartcard reader driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <45D994FB.2080606@amd.com>
Date:	Mon, 19 Feb 2007 13:15:55 +0100
From:	"Markus Rechberger" <markus.rechberger@....com>
To:	"Éric Piel" <Eric.Piel@...mplin-utc.net>,
	"Oliver Neukum" <oliver@...kum.org>,
	"LKML" <linux-kernel@...r.kernel.org>
Subject: Re: O2micro smartcard reader driver.


On 2/19/07, Éric Piel <Eric.Piel@...mplin-utc.net> wrote:
> 02/17/2007 04:55 AM, Markus Rechberger wrote/a écrit:
> > Hi Eric,
> >
> > I committed your code to linuxtv.org to review and modify it there.
> > http://linuxtv.org/hg/~mrechberger/chipcardreader
> >
> > one thing I noticed is the error handling in ozscr_probe.
> >
> > I'll continue the rest during the next few days, I'd like to see it as
> > soon as possible in the upstream kernel before some kernel api changes
> > again which affects your current driver.
>
> Hi Markus,
>
> Thank you very much for finding new bugs ;-) Actually, right now I've
> just moved and don't have internet at home which is kind of slowing down
> development... Anyway, I'll check if I have some more fixes on my
> computer than on my website. Also, it would be good to double check some
> lines which I've commented XXX. In particular, IIRC there were some
> suspicious sleep saying it was sleeping a microsecond and sleeping one
> millisecond!

as user noone cares if it's 1 ns or 1 ms, since that part seems to work
as it is just leave it.

>
> I'm also a bit concerned about the userspace "driver" for pscd which
> comes with the original driver once the patch will be part of the
> default kernel. Maybe this userspace part could become part of the
> pscdlite distribution.
>

I couldn't find the sources of the userspace library, the link on
musclecard.com is dead (and there's no backup on archive.org)

> Wrt the module having always a usecount value of 1, it was worrying me
> too at the begining until I noticed it decreased back to 0 once the card
> is "ejected" (pccardctl eject 1). Although a bit surprising, I don't
> think it's a bug, is it?

this is where the pcmcia/pccard framework bug becomes relevant. The
usecount is no bug, but the lockup (which got explained in the other
mail) is one
>
> See you,
> Eric
>
>


-- 
Markus Rechberger
Operating System Research Center
AMD Saxony LLC & Co. KG



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/