linux-kernel - Re: [-mm patch] fix locking in __make_request (was Re: 2.6.20-mm2: Oops in generic_make

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 20 Feb 2007 14:32:01 +0000
From:	Frederik Deweerdt <deweerdt@...e.fr>
To:	Michal Piotrowski <michal.k.k.piotrowski@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Mattia Dongili <malattia@...ux.it>,
	Laurent Riffard <laurent.riffard@...e.fr>,
	linux-kernel@...r.kernel.org, axboe@...nel.dk,
	Jens Axboe <jens.axboe@...cle.com>
Subject: Re: [-mm patch] fix locking in __make_request (was Re: 2.6.20-mm2: Oops in generic_make_request)

On Mon, Feb 19, 2007 at 03:08:03PM +0100, Michal Piotrowski wrote:
> Michal Piotrowski napisał(a):
> > Hi Frederik,
> > 
> > On 20/02/07, Frederik Deweerdt <deweerdt@...e.fr> wrote:
> >> Hi Michal,
> >>
> >> This seems to be a locking problem in __make_request, check_plug_merge()
> >> should be called with the q->queue_lock held.
> >> Could you try the following patch? It silenced the oops for me.
> > 
> > For me too, but Jens dislikes this patch.
> 
> Now I know why...
> 
> Code:  Bad EIP value.
> EIP: [<6b6b6b6b>] 0x6b6b6b6b SS:ESP 0068:f45f9bf8

:) It may not be related though. I think that my patch avoids the
BUG_ON(!rq_mergeable(req)); in ll_rw_blk.c:2782. This looks like another
beast to me.

Regards,
Frederik
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/