lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 19 Feb 2007 10:46:43 -0800 From: David Brownell <david-b@...bell.net> To: Nicolas Ferre <nicolas.ferre@....atmel.com> Cc: linux-kernel@...r.kernel.org, Patrice Vilchez <patrice.vilchez@....atmel.com>, Andrew Victor <andrew@...people.com> Subject: Re: [PATCH] input/spi: add ads7843 support to ads7846 touchscreen driver On Monday 19 February 2007 4:48 am, Nicolas Ferre wrote: > > >> - /* maybe off internal vREF */ > >> - if (use_internal) { > > > > This part doesn't make sense. Could you say what you're trying > > to do? The ads7846 requres an external vREF. Is the issue that > > maybe the REF_OFF command isn't just turning off the (non-existent) > > internal voltage reference? If so the comments need updating, and > > maybe the name REF_OFF needs to change too... > > Well, on the ads7843, this command allow to put converter in low power > mode and, more important, enable the PENIRQ (otherwise disabled). > > The REF_OFF command can be replaced by the PWRDOWN one (exactly the > same command). This last name matches better the ads7843 > datasheet description (and seems ok considering the ads7846 one). OK, that would be a better change then, along with comment update. - Dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists