[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070220130701.00503673@localhost.localdomain>
Date: Tue, 20 Feb 2007 13:07:01 +0000
From: Alan <alan@...rguk.ukuu.org.uk>
To: David Gibson <david@...son.dropbear.id.au>
Cc: Andrew Morton <akpm@...l.org>, <linux-kernel@...r.kernel.org>,
<rmk@....linux.org.uk>, <linuxppc-dev@...abs.org>
Subject: Re: [PATCH 1/2] Define FIXED_PORT flag for serial_core
On Tue, 20 Feb 2007 14:19:51 +1100 (EST)
David Gibson <david@...son.dropbear.id.au> wrote:
> At present, the serial core always allows setserial in userspace to
> change the port address, irq and base clock of any serial port. That
> makes sense for legacy ISA ports, but not for (say) embedded ns16550
> compatible serial ports at peculiar addresses. In these cases, the
> kernel code configuring the ports must know exactly where they are,
> and their clocking arrangements (which can be unusual on embedded
> boards). It doesn't make sense for userspace to change these
> settings.
>
> Therefore, this patch defines a UPF_FIXED_PORT flag for the uart_port
> structure. If this flag is set when the serial port is configured,
> any attempts to alter the port's type, io address, irq or base clock
> with setserial are ignored.
>
> In addition this patch uses the new flag for on-chip serial ports
> probed in arch/powerpc/kernel/legacy_serial.c, and for other
> hard-wired serial ports probed by drivers/serial/of_serial.c.
>
> Signed-off-by: David Gibson <dwg@....ibm.com>
>
Acked-by: Alan Cox <alan@...hat.com>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists