[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0702211302300.4043@woody.linux-foundation.org>
Date: Wed, 21 Feb 2007 13:06:17 -0800 (PST)
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Daniel Walker <dwalker@...sta.com>
cc: tglx@...utronix.de,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
mingo@...e.hu
Subject: Re: Linux 2.6.21-rc1
On Wed, 21 Feb 2007, Daniel Walker wrote:
>
> Here's the final commit from the bisect which caused it . It says "No
> changes to existing functionality" ?
Ok, it wouldn't be the first time some change that is supposed to change
nothing does actually change something.
That said, one thing to worry about when doing bisection: the kernel
configuration.
If you always just do "make oldconfig" or something, the kernel config for
the thing you test will depend on the _previous_ kernel you compiled, and
that is not always what you want. I've once had a failing kernel, did
bisection, and it turned out that since I had gone back in time to before
the option that caused the failure even existed, I had (by mistake) then
compiled some of the later kernels without that option enabled, and called
them "good".
The end result: "git bisect" didn't actually end up pointing to the right
commit, just because I had effectively lied to it.
That said, considering that you did get a commit that doesn't look
entirely unlikely (and that clearly changes things that are relevant), I
suspect you did actually find the right one.
Linus
---
> commit e9e2cdb412412326c4827fc78ba27f410d837e6e
> Author: Thomas Gleixner <tglx@...utronix.de>
> Date: Fri Feb 16 01:28:04 2007 -0800
>
> [PATCH] clockevents: i386 drivers
>
> Add clockevent drivers for i386: lapic (local) and PIT/HPET (global). Update
> the timer IRQ to call into the PIT/HPET driver's event handler and the
> lapic-timer IRQ to call into the lapic clockevent driver. The assignement of
> timer functionality is delegated to the core framework code and replaces the
> compile and runtime evalution in do_timer_interrupt_hook()
>
> Use the clockevents broadcast support and implement the lapic_broadcast
> function for ACPI.
>
> No changes to existing functionality.
>
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists