linux-kernel - Re: [PATCH] libata: add NCQ blacklist entries from Silicon Image Windows driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070222113226.GI5549@kernel.dk>
Date:	Thu, 22 Feb 2007 12:32:28 +0100
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	Robert Hancock <hancockr@...w.ca>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-ide@...r.kernel.org, Andrew Morton <akpm@...l.org>,
	Tejun Heo <htejun@...il.com>
Subject: Re: [PATCH] libata: add NCQ blacklist entries from Silicon Image  Windows driver

On Thu, Feb 22 2007, Jeff Garzik wrote:
> Robert Hancock wrote:
> >This patch adds in some NCQ blacklist entries taken from the Silicon
> >Image Windows drivers' .inf files for the 3124 and 3132 controllers.
> >These entries were marked as ""DisableSataQueueing". Assume these are
> >in their blacklist for a reason and disable NCQ on these drives.
> >
> >Signed-off-by: Robert Hancock <hancockr@...w.ca>
> >
> >--- linux-2.6.21-rc1edit/drivers/ata/libata-core.c.prev    2007-02-21 
> >22:23:05.000000000 -0600
> >+++ linux-2.6.21-rc1edit/drivers/ata/libata-core.c    2007-02-21 
> >22:25:44.000000000 -0600
> >@@ -3269,6 +3269,13 @@ static const struct ata_blacklist_entry
> >    /* Devices with NCQ limits */
> >
> >+    /* The following blacklist entries are taken from the Windows
> >+       driver .inf files for the Silicon Image 3124 and 3132. */
> >+    { "Maxtor 7B250S0",    "BANC1B70",    ATA_HORKAGE_NONCQ, },
> >+    { "HTS541060G9SA00",    "MB3OC60D",    ATA_HORKAGE_NONCQ, },
> >+    { "HTS541080G9SA00",    "MB4OC60D",    ATA_HORKAGE_NONCQ, },
> >+    { "HTS541010G9SA00",    "MBZOC60D",    ATA_HORKAGE_NONCQ, },
> 
> Do we have information that these drives fail on non-SiI controllers?
> 
> Sometimes the problem can be related to a single family of controllers.

I don't know about the Hitachi's, but the Maxtor with that firmware is
definitely broken. It _appeared_ to work if the depth was limited to 4,
but I didn't test it long enough to be absolutely certain. So the safest
is indeed to blacklist it.

I'm pretty sure my initial NCQ patches had a blacklist entry for that
drive as well, but apparently the blacklist got lost somewhere along the
way?

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/