lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 Feb 2007 11:43:00 +0000 From: David Howells <dhowells@...hat.com> To: Andrew Morton <akpm@...ux-foundation.org> Cc: torvalds@...ux-foundation.org, dwmw2@...radead.org, linux-kernel@...r.kernel.org, uclinux-dev@...inux.org, linux-mtd@...ts.infradead.org Subject: Re: [PATCH 4/4] NOMMU: Make it possible for RomFS to use MTD devices directly Andrew Morton <akpm@...ux-foundation.org> wrote: > > + brelse(bh); > > A little fyi: brelse() is rather old-fashioned, and has a usually unneeded > test for non-null bh in it. In situations where we know that the pointer is > valid, let's please use put_bh(). That's what was in the old romfs. I can make the change, though. Hmmm... brelse() isn't quite equivalent to put_bh(), but the difference seems just to be the message you get if you over-release a buffer head - and the resulting refcount on the BH if that happens. > Anyway, I'll assume that dwmw2 will be handling this patch series. I assume so. David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists