linux-kernel - Re: [PATCH 2/7] cxgb3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45DD8DDA.8060303@chelsio.com>
Date:	Thu, 22 Feb 2007 04:34:34 -0800
From:	Divy Le Ray <divy@...lsio.com>
To:	yoshfuji@...ux-ipv6.org
CC:	divy@...lsio.com, jeff@...zik.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, swise@...ngridcomputing.com,
	yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH 2/7] cxgb3 - private ioctl cleanup

Hi Yoshfuji,
>> From: Divy Le Ray <divy@...lsio.com>
>>
>> Clean up some private ioctls.
>>
>> Signed-off-by: Divy Le Ray <divy@...lsio.com>
>> ---
>>
>>  drivers/net/cxgb3/cxgb3_ioctl.h |   21 ++++-------------
>>  drivers/net/cxgb3/cxgb3_main.c  |   48 +++------------------------------------
>>  2 files changed, 9 insertions(+), 60 deletions(-)
>>
>> diff --git a/drivers/net/cxgb3/cxgb3_ioctl.h b/drivers/net/cxgb3/cxgb3_ioctl.h
>> index a942818..42d4bf6 100644
>> --- a/drivers/net/cxgb3/cxgb3_ioctl.h
>> +++ b/drivers/net/cxgb3/cxgb3_ioctl.h
>> @@ -36,28 +36,17 @@
>>   * Ioctl commands specific to this driver.
>>   */
>>  enum {
>> -	CHELSIO_SETREG = 1024,
>> -	CHELSIO_GETREG,
>> -	CHELSIO_SETTPI,
>> -	CHELSIO_GETTPI,
>> -	CHELSIO_GETMTUTAB,
>> +	CHELSIO_GETMTUTAB = 1024,
>>  	CHELSIO_SETMTUTAB,
>> -	CHELSIO_GETMTU,
>> -	CHELSIO_SET_PM,
>> -	CHELSIO_GET_PM,
>> -	CHELSIO_GET_TCAM,
>> -	CHELSIO_SET_TCAM,
>> -	CHELSIO_GET_TCB,
>>  	CHELSIO_GET_MEM,
>>  	CHELSIO_LOAD_FW,
>> -	CHELSIO_GET_PROTO,
>> -	CHELSIO_SET_PROTO,
>>  	CHELSIO_SET_TRACE_FILTER,
>> -	CHELSIO_SET_QSET_PARAMS,
>>  	CHELSIO_GET_QSET_PARAMS,
>> -	CHELSIO_SET_QSET_NUM,
>> +	CHELSIO_SET_QSET_PARAMS,
>>  	CHELSIO_GET_QSET_NUM,
>> -	CHELSIO_SET_PKTSCHED,
>> +	CHELSIO_SET_QSET_NUM,
>> +	CHELSIO_GET_PM,
>> +	CHELSIO_SET_PM,
>>  };
>>  
>>     
>
> I disagree. This is very bad.
>
> 1. Please do do change the values.
> 2. Explain why you are going to kill these ioctls.
>   
Jeff and Arjan have required that most of these ioctls go.
Please read:
http://marc.theaimsgroup.com/?l=linux-netdev&m=117029584904193&w=2

Cheers,
Divy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/