linux-kernel - Re: [Patch 2/2] cciss: add shutdown support (replaces reboot notifier)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070222215501.GA21037@infradead.org>
Date:	Thu, 22 Feb 2007 21:55:01 +0000
From:	Christoph Hellwig <hch@...radead.org>
To:	James Bottomley <James.Bottomley@...elEye.com>
Cc:	"Mike Miller (OS Dev)" <mikem@...rdog.cca.cpqcorp.net>,
	akpm@...l.org, jens.axboe@...cle.com, linux-kernel@...r.kernel.org,
	linux-scsi@...r.kernel.org, gregkh@...ell.com, hch@...radead.org
Subject: Re: [Patch 2/2] cciss: add shutdown support (replaces reboot notifier)

On Thu, Feb 22, 2007 at 03:49:38PM -0600, James Bottomley wrote:
> On Thu, 2007-02-22 at 15:38 -0600, Mike Miller (OS Dev) wrote:
> >         .remove = __devexit_p(cciss_remove_one),
> >         .id_table = cciss_pci_device_id,        /* id_table */
> > +       .shutdown = cciss_remove_one,
> 
> You need a __devexit_p() wrapper for this one too.

No.  We want to call this even in the non-modular, non-hotplug
case.  So we should remove __devexit from cciss_remove_one.  Or
alternatively implement a separate cciss_shutdown that just does
the nessecary cache flushing, like most other drivers do.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/