[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.60.0702222352460.6771@poirot.grange>
Date: Thu, 22 Feb 2007 23:58:55 +0100 (CET)
From: Guennadi Liakhovetski <g.liakhovetski@....de>
To: Johannes Berg <johannes@...solutions.net>,
David Brownell <david-b@...bell.net>
cc: linuxppc-dev@...abs.org, rtc-linux@...glegroups.com,
linux-pm@...ts.osdl.org, Torrance <torrance123@...il.com>,
Alessandro Zummo <alessandro.zummo@...ertech.it>,
john stultz <johnstul@...ibm.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Linux Kernel list <linux-kernel@...r.kernel.org>
Subject: Re: several messages
of the following 2 patches:
On Mon, 5 Feb 2007, Johannes Berg wrote:
> This patch removes the time suspend/restore code that was done through
> a PMU notifier in arch/platforms/powermac/time.c.
>
> Instead, we introduce arch/powerpc/sysdev/timer.c which creates a sys
> device and handles time of day suspend/resume through that.
>
> Signed-off-by: Johannes Berg <johannes@...solutions.net>
> Cc: Andrew Morton <akpm@...l.org>
> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
[patch trimmed]
On Wed, 21 Feb 2007, David Brownell wrote:
> RTC class suspend/resume support, re-initializing the system clock on resume
> >from the clock used to initialize it at boot time.
>
> - Inlining the same code used by ARM, which saves and restores the
> delta between a selected RTC and the current system wall-clock time.
>
> - Removes calls to that ARM code from AT91, OMAP, and S3C RTCs.
>
> This goes on top of the patch series removing "struct class_device" usage
> >from the RTC framework. That makes class suspend()/resume() work.
>
> Signed-off-by: David Brownell <dbrownell@...rs.sourceforge.net>
>
> ---
> drivers/rtc/Kconfig | 24 +++++++++----
> drivers/rtc/class.c | 74 +++++++++++++++++++++++++++++++++++++++++++
> drivers/rtc/rtc-at91rm9200.c | 30 -----------------
> drivers/rtc/rtc-omap.c | 17 ---------
> drivers/rtc/rtc-s3c.c | 22 ------------
> 5 files changed, 91 insertions(+), 76 deletions(-)
[patch trimmed]
I think, we only want 1, right? And the latter seems to be more generic /
platform independent? And as a side-effect, powermac would have to migrate
to generic rtc:-)
Thanks
Guennadi
---
Guennadi Liakhovetski
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists