linux-kernel - Re: [patch 2/2] sched: dynticks idle load balancing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070222031406.GC12137@wotan.suse.de>
Date:	Thu, 22 Feb 2007 04:14:06 +0100
From:	Nick Piggin <npiggin@...e.de>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	"Siddha, Suresh B" <suresh.b.siddha@...el.com>, mingo@...e.hu,
	linux-kernel@...r.kernel.org, rostedt@...dmis.org
Subject: Re: [patch 2/2] sched: dynticks idle load balancing - v2

On Wed, Feb 21, 2007 at 12:23:44PM -0800, Andrew Morton wrote:
> On Fri, 16 Feb 2007 18:08:42 -0800

> > +int select_nohz_load_balancer(int stop_tick)
> > +{
> > +	int cpu = smp_processor_id();
> > +
> > +	if (stop_tick) {
> > +		cpu_set(cpu, nohz.cpu_mask);
> > +		cpu_rq(cpu)->in_nohz_recently = 1;
> > +
> > +		/*
> > +		 * If we are going offline and still the leader, give up!
> > +		 */
> > +		if (cpu_is_offline(cpu) && nohz.load_balancer == cpu) {
> > +			if (cmpxchg(&nohz.load_balancer,  cpu, -1) != cpu)
> 
> So we require that architectures which implement CONFIG_NO_HZ also
> implement cmpxchg.

Just use atomic_cmpxchg, please.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/