linux-kernel - Re: [PATCH] slab: remove colouroff from struct slab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0702230550270.27654@schroedinger.engr.sgi.com>
Date:	Fri, 23 Feb 2007 06:00:37 -0800 (PST)
From:	Christoph Lameter <clameter@...r.sgi.com>
To:	Pekka J Enberg <penberg@...helsinki.fi>
cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	wli@...omorphy.com
Subject: Re: [PATCH] slab: remove colouroff from struct slab

On Thu, 22 Feb 2007, Pekka J Enberg wrote:

> As the color offset is always within the first page of the slab,
> virt_to_page() works just fine without slabp->colouroff.

True but then we pass an address to kmem_freepages that is not the start 
of the page. kmem_freepages will then in turn call free_pages() with an 
address that is not the start of a page. free_pages() will then do another 
virt_to_page() which ignored the offset into the page again. And so the 
approach works but an uneasy feeling remains since the address we got from 
kmem_getpages() is different from what we pass to kmem_freepages().

Could you think about a way to do this in a cleaner way? Maybe use a 
struct page * in both kmem_get/freepages? Or add some comment explaining 
the situation?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/