[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070223143938.GA5815@tuxdriver.com>
Date: Fri, 23 Feb 2007 09:39:38 -0500
From: "John W. Linville" <linville@...driver.com>
To: Kyle McMartin <kyle@...isc-linux.org>
Cc: Heiko Carstens <heiko.carstens@...ibm.com>,
linux-kernel@...r.kernel.org, James.Bottomley@...elEye.com,
Tejun Heo <htejun@...il.com>, Jeff Garzik <jeff@...zik.org>,
Martin Schwidefsky <schwidefsky@...ibm.com>
Subject: Re: [PATCH] dma-mapping-broken.h: flesh-out DMA API stubs
On Fri, Feb 23, 2007 at 08:57:41AM -0500, Kyle McMartin wrote:
> On Fri, Feb 23, 2007 at 07:13:32AM +0100, Heiko Carstens wrote:
> > How about this for telling that an architecture doesn't support DMA?
> > At least we could get rid of dma-mapping-broken.h and don't need to
> > compile some afterwards dead code.
> >
> > Signed-off-by: Heiko Carstens <heiko.carstens@...ibm.com>
>
> This like a lot better of an idea than stubbing out things which should never
> be built in the first place...
My only thought was that the intent must have been to allow compilation of a driver
that checks for DMA at runtime (via dma_supported). But, I guess dma_supported is intended
as a platform-level check?
If the DMA availability is at the arch level then such a driver could
use (albeit ugly) compile flags to cover that situation...?
Well, either way is fine with me.
John
--
John W. Linville
linville@...driver.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists