linux-kernel - Re: [linux-usb-devel] [PATCH 2/2] usbatm: Detect usb device shutdown and ignore failed urbs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0702231306450.14262-100000@netrider.rowland.org>
Date:	Fri, 23 Feb 2007 13:11:59 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Duncan Sands <duncan.sands@...h.u-psud.fr>
cc:	Pete Zaitcev <zaitcev@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	<linux-usb-devel@...ts.sourceforge.net>,
	Simon Arlott <254ad70138dc1cdf241hjzcr0007jhhw@...nder.lp0.eu>
Subject: Re: [linux-usb-devel] [PATCH 2/2] usbatm: Detect usb device shutdown
 and ignore failed urbs.

On Fri, 23 Feb 2007, Duncan Sands wrote:

> Thanks Alan.  The original question was: if an urb fails with an error,
> is there any point in resubmitting it after a delay (which is what the
> driver usually does) if the error was -ESHUTDOWN?  It sounds like there
> is no point to it.

No, there isn't.

>  And if the device is not disconnected, then it could
> even be harmful since the urb will be resubmitted endlessly...  While on
> the topic, are there any other error codes for which an urb should not be
> resubmitted?

Let's see...  ENOENT and ECONNRESET indicate the URB was unlinked, so you
probably don't want to resubmit it.  EPIPE indicates a problem on the 
device end, so you would want to fix the problem before resubmitting (at 
the very least you would want to clear the halt).  EOVERFLOW is 
questionable; if the device sent too much data once then it might do so 
again.  Ditto for EREMOTEIO (the device sent too little data).  ENODEV 
means the device was removed, so you definitely don't want to resubmit.

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/