linux-kernel - [patch] fix the irq migration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070222172135.A27563@unix-os.sc.intel.com>
Date:	Thu, 22 Feb 2007 17:21:36 -0800
From:	"Siddha, Suresh B" <suresh.b.siddha@...el.com>
To:	mingo@...e.hu
Cc:	ebiederm@...ssion.com, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: [patch] fix the irq migration

While debugging some other irq migration issue, observed this issue with
-git kernels. Ingo, please ACK it.
---

With the commit 76d2160147f43f982dfe881404cfde9fd0a9da21, irq_chip
default_disable() became an empty function. And with this change, irq
migration in the case of Edge triggered IO-APIC and MSI interrupts happens
with out masking the irq.

Appended patch fixes by using the mask/unmask handlers of irq_chip directly
while doing the irq migration.

Signed-off-by: Suresh Siddha <suresh.b.siddha@...el.com>
---

diff --git a/kernel/irq/migration.c b/kernel/irq/migration.c
index 4baa3bb..14ff345 100644
--- a/kernel/irq/migration.c
+++ b/kernel/irq/migration.c
@@ -66,11 +66,11 @@ void move_native_irq(int irq)
 		return;
 
 	if (likely(!(desc->status & IRQ_DISABLED)))
-		desc->chip->disable(irq);
+		desc->chip->mask(irq);
 
 	move_masked_irq(irq);
 
 	if (likely(!(desc->status & IRQ_DISABLED)))
-		desc->chip->enable(irq);
+		desc->chip->unmask(irq);
 }
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/