linux-kernel - Re: [PATCH] USB Elan FTDI: check for workqueue creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070223075322.GA10055@cvg>
Date:	Fri, 23 Feb 2007 10:53:22 +0300
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Pete Zaitcev <zaitcev@...hat.com>
Cc:	linux-kernel-list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] USB Elan FTDI: check for workqueue creation

On Thu, Feb 22, 2007 at 03:55:23PM -0800, Pete Zaitcev wrote:
| On Mon, 19 Feb 2007 21:15:49 +0300, Cyrill Gorcunov <gorcunov@...il.com> wrote:
| 
| > +++ b/drivers/usb/misc/ftdi-elan.c
| > @@ -57,9 +57,9 @@ module_param(distrust_firmware, bool, 0);
| >  MODULE_PARM_DESC(distrust_firmware, "true to distrust firmware power/overcurren"
| >          "t setup");
| >  extern struct platform_driver u132_platform_driver;
| > -static struct workqueue_struct *status_queue;
| > +static struct workqueue_struct *status_queue = NULL;
| 
| You better drop this part. Someone is bound to object.
| 
| -- Pete
| 

Hi,

actually I don't understand why... Event on ftdi_elan_exit()
status_queue is setting up to NULL. And what is bound to object?
Could you write more detailed?

		Cyrill

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/