linux-kernel - [PATCH] scsi: eata.c potential namespace collision and optimisation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20070224140846.GB7939@zakalwe.fi>
Date:	Sat, 24 Feb 2007 16:08:46 +0200
From:	Heikki Orsila <shdl@...alwe.fi>
To:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:	ballabio_dario@....com, linux-scsi@...r.kernel.org
Subject: [PATCH] scsi: eata.c potential namespace collision and optimisation

This fixes a potential namespace collision and does an optimisation for 
2.6.20 drivers/scsi/eata.c:

	* sort() is renamed to eata_sort() to avoid conflict with kernel 
	  proper sort(). It does _not_ conflict currently in 2.6.20 so 
	  this is a pre-emptive change.

	* in eata_sort(), one if-condition per loop iteration is avoided
	  by moving the comparison out of the loop

Warning: The patch compiles but is not tested with real hardware since I 
don't have the card.

diffstat:
 eata.c |   19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

Signed-off-by: Heikki Orsila <heikki.orsila@....fi>

-- 
Heikki Orsila			Barbie's law:
heikki.orsila@....fi		"Math is hard, let's go shopping!"
http://www.iki.fi/shd

View attachment "2.6.20-eata-namespace.diff" of type "text/plain" (1548 bytes)