linux-kernel - [2.6 patch] kconfig: abort configuration with recursive dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20070225231833.GC29575@stusta.de>
Date:	Mon, 26 Feb 2007 00:18:33 +0100
From:	Adrian Bunk <bunk@...sta.de>
To:	zippel@...ux-m68k.org, Andrew Morton <akpm@...ux-foundation.org>
Cc:	kbuild-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: [2.6 patch] kconfig: abort configuration with recursive dependencies

A recursive kconfig dependency is a bug that has to be fixed, and that 
might currently not be noted until booting the built kernel.

Currently, the warning that a recursive dependency was detected scrolls 
away during "make oldconfig", and often people don't notice until they 
booted the kernel and note something like "Why is there no IPV6 support?".

This patch therefore lets the configuration fail if kconfig found a 
recursive dependency.

Signed-off-by: Adrian Bunk <bunk@...sta.de>

--- linux-2.6.20-mm2/scripts/kconfig/symbol.c.old	2007-02-25 19:27:07.000000000 +0100
+++ linux-2.6.20-mm2/scripts/kconfig/symbol.c	2007-02-25 19:30:32.000000000 +0100
@@ -792,7 +792,7 @@
 	struct property *prop;
 
 	if (sym->flags & SYMBOL_CHECK) {
-		printf("Warning! Found recursive dependency: %s", sym->name);
+		printf("Error: Found recursive dependency: %s", sym->name);
 		return sym;
 	}
 	if (sym->flags & SYMBOL_CHECKED)
@@ -820,7 +820,7 @@
 		printf(" %s", sym->name);
 		if (sym2 == sym) {
 			printf("\n");
-			sym2 = NULL;
+			exit(1);
 		}
 	}
 	sym->flags &= ~SYMBOL_CHECK;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/