linux-kernel - Re: [patch 01/18] bcm43xx: Fix for oops on resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070225005330.50ec3280.akpm@linux-foundation.org>
Date:	Sun, 25 Feb 2007 00:53:30 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Larry Finger <larry.finger@...inger.net>
Cc:	pavel@....cz, greg@...ah.com, linux-kernel@...r.kernel.org,
	stable@...nel.org, jmforbes@...uxtx.org, zwane@....linux.org.uk,
	tytso@....edu, rdunlap@...otime.net, davej@...hat.com,
	chuckw@...ntumlinux.com, reviews@...cw.f00f.org,
	mkrufky@...uxtv.org, torvalds@...ux-foundation.org,
	alan@...rguk.ukuu.org.uk
Subject: Re: [patch 01/18] bcm43xx: Fix for oops on resume

> On Sat, 24 Feb 2007 20:30:41 -0600 Larry Finger <larry.finger@...inger.net> wrote:
> Pavel Machek wrote:
> > Hi!
> > 
> >> -stable review patch.  If anyone has any objections, please let us know.
> >>
> >> ------------------
> >> From: Larry Finger <Larry.Finger@...inger.net>
> >>
> >> There is a kernel oops on bcm43xx when resuming due to an overly tight timeout loop.
> >>
> >> Signed-off-by: Larry Finger <Larry.Finger@...inger.net>
> >> Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
> >>
> >> ---
> >>  drivers/net/wireless/bcm43xx/bcm43xx.h |    2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> --- linux-2.6.18.7.orig/drivers/net/wireless/bcm43xx/bcm43xx.h
> >> +++ linux-2.6.18.7/drivers/net/wireless/bcm43xx/bcm43xx.h
> >> @@ -21,7 +21,7 @@
> >>  #define PFX				KBUILD_MODNAME ": "
> >>  
> >>  #define BCM43xx_SWITCH_CORE_MAX_RETRIES	50
> >> -#define BCM43xx_IRQWAIT_MAX_RETRIES	50
> >> +#define BCM43xx_IRQWAIT_MAX_RETRIES	100
> >>  
> >>  #define BCM43xx_IO_SIZE			8192
> > 
> > I'm sorry, but this does not look like fixing an oops. It may make it
> > go away for you, or make it less probable, but it certainly can't fix
> > it.
> 
> Upon resume, it was taking 65 times through the loop, which caused an oops. We think it is due to a
> slow-clock setting at that point, but it certainly does get rid of the oops. This change has also
> eliminated the odd oops seen by a few users.
> 

Pavel's point is that the driver shouldn't oops the kernel if
BCM43xx_IRQWAIT_MAX_RETRIES is exceeded.

Presumably, the driver will oops if bcm43xx_chip_init() fails for other
reasons?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/